PWA: Only allow the install bar when the WordCamp is approaching/running #315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prevents Chrome from displaying the mini-infobar ("Add [WordCamp] to your home screen") when the event is more than 2 weeks away.
coreymckrill
approved these changes
Jan 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents Chrome from displaying the mini-infobar ("Add [WordCamp] to your home screen") when the event is more than 2 weeks away. This is only added to sites that have the PWA plugin active.
See #129 for discussion around removing vs limiting the banner.
How to test the changes in this Pull Request:
As far as I can tell, the banner only shows up on Android + Chrome, so to functionally test, you need an Android & to proxy your sandbox so you can access it from mobile. I used Charles for this, but you could also just verify that the code to prevent the banner appears when expected (2 weeks before until 1 week after the start date of the camp, for any site that has the PWA plugin active).