Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Components: Fix placeholder color inconsistency across SearchControl, TextControl, Inputcontrol #68807

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

im3dabasia
Copy link
Contributor

Closes: #64666

What?

This PR ensures a consistent placeholder color across the InputControl, SearchControl, and TextControl components by defining the color explicitly.

Why?

To address the issue where placeholder color varied depending on the applied styles.

How?

The placeholder color has been defined at the component level to avoid inconsistencies and improve accessibility.

Testing Instructions

  1. Test the InputControl, SearchControl, and TextControl components in the storybook
  2. Ensure the placeholder color is consistent and meets the contrast ratio requirements.
Component Foreground Color Background Color
InputControl #1e1e1e9e (dark gray 62% opacity) #ffffff (white)
SearchControl #1e1e1e9e (dark gray 62% opacity) #f0f0f0 (light gray)
TextControl #1e1e1e9e (dark gray 62% opacity) #ffffff (white)

@im3dabasia im3dabasia requested a review from ajitbohra as a code owner January 21, 2025 13:12
@im3dabasia
Copy link
Contributor Author

  • This PR aims to standardize the placeholder colors for the three components mentioned above. There has been an ongoing discussion about potentially removing the light gray color from the SearchControl, as noted in this issue comment.

  • I am happy to take on the task of working on removing the color, if needed.

Copy link

Warning: Type of PR label mismatch

To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.

  • Type-related labels to choose from: [Type] Automated Testing, [Type] Breaking Change, [Type] Bug, [Type] Build Tooling, [Type] Code Quality, [Type] Copy, [Type] Developer Documentation, [Type] Enhancement, [Type] Experimental, [Type] Feature, [Type] New API, [Type] Task, [Type] Technical Prototype, [Type] Performance, [Type] Project Management, [Type] Regression, [Type] Security, [Type] WP Core Ticket, Backport from WordPress Core, Gutenberg Plugin.
  • Labels found: .

Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task.

Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: im3dabasia <[email protected]>
Co-authored-by: t-hamano <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@im3dabasia
Copy link
Contributor Author

Hi @t-hamano,

When you have a moment, please review my changes and provide feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Components: Apply consistent placeholder color
1 participant