Query Loop: It doesn't show sticky posts at the top when the query type is the default in the editor.

[dhananjaykuber]

Fixes #68570

What?

Fixes the issue where sticky posts were not appearing at the top of Query Loop block results in the editor view, while they do appear at the top on the front end.

Why?

There was an inconsistency between how sticky posts were displayed in the editor versus the front end. This caused confusion for users as the editor preview didn't accurately reflect what visitors would see on the site. The issue occurs because the editor view wasn't properly handling the sticky post ordering, while the PHP rendering on the front end did show sticky posts at the top by default.

Testing Instructions

1. Create or edit a page that uses the Query Loop block
2. Make sure you have at least one sticky post on your site (you can make a post sticky in the post editor's Document Settings panel)
3. In the editor, observe that sticky posts now appear at the top of the Query Loop results
4. Preview the page on the front end to verify that the editor view matches the front-end display

Screenshots or screencast

[github-actions]

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: dhananjaykuber <[email protected]>
Co-authored-by: carolinan <[email protected]>
Co-authored-by: iamtakashi <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

[carolinan]

Thank you for working on this, it would be great to have this fixed.

I don't think the logic is correct: When I switch the post type option on the query block to use pages, they show twice in the editor. If I then switch back from pages to posts, the pages still show in the editor.

[dhananjaykuber]

Hi @carolinan,

Thank you for pointing out the bug, I have fixed it and tested on my local

[carolinan]

I have tested order, filters, switching post type, include, exclude and only without finding any issues.
I would like to see some more reviews in case I missed something.

[carolinan]

Perhaps these two conditions could be combined into one, where the value of sticky depends on if it is only/exclude?
It depends on what everyone prefers in terms of readability, but also on how we want to manage the introduction of ignore, #66222, which relies on this issue.

[Mamaduka]

PR needs more work based on the conditions; the Query block might make three REST API calls to retrieve posts, negatively impacting the Site Editor loading performance.

Ideally, it should only make one and Sticky post logic should be baked in the REST controller.