Make SiteHub available in mobile viewports: Try moving sidebar navigation context up higher #63109
+132
−133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -9 B (0%) Total Size: 1.75 MB
ℹ️ View Unchanged
|
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Update: I was hoping this might help fix things, but it looks like the 2024-07-04.13.38.42.mp4 |
|
Closing this out, as I think I've found a simpler fix for the focus issue over in 4401f60 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Split out from #63060, this PR attempts to move the
SidebarNavigationContextprovider up to the layout in the site editor.Note: this PR targets
try/sitehub-mobileinstead oftrunkto (hopefully) make it easier to see what's going on.Why?
So that we don't need to wrap the site hub in the
SidebarContentcomponent which was causing issues with which buttons are focused, and added unnecessary padding.I've created this as a separate PR just to see if the idea works, and to make it easier to throw away than committing to #63060.
How?
<SidebarContent>wrapping for the site hubSidebarNavigationContextprovider up to the layout so that the context can be shared with the site hub, without requiring extra wrappingTesting Instructions
Same as for #63060
Note: when looking at this PR, you might want to look at it with whitespace removed so that the diff is easier to read: https://github.com/WordPress/gutenberg/pull/63109/files?diff=unified&w=1
Testing Instructions for Keyboard
Screenshots or screencast