Make BlockPopover component public

[gigitux]

What?

Note

This PR is just a draft to get feedback. If making sense to make the BlockPopover component public, I would suggest marking it as an unstable API and improving the documentation.

This PR makes the BlockPopover component public.

Why?

Currently, a consumer can add the Gutenberg toolbar block with the BlockToolbar component. Hoverwer, the BlockToolbar isn't flexible, and it is complex to hide/show different buttons and text.

Making BlockPopover public allows a consumer to create a custom BlockToolbar and customize it according to application needs.

This PR could be part of #53874.

You can check woocommerce/woocommerce#47323 and woocommerce/woocommerce#47322 for a real-use case.

How?

Testing Instructions

Testing Instructions for Keyboard

Screenshots or screencast

[youknowriad]

Hi there!, Thanks for opening this PR.

I would love more opinions on the PR (maybe @ellatrix) but I think making this component a public one is fine. But I'd probably make the two unstable props "private" before opening the component. (have a private version of the component and a public one)

[youknowriad]

Adding a JSDoc to the component helps with this. Also the component already has a README, so you might be able to reuse the README content.

[gigitux]

I updated the PR, and I'm opening it to be reviewed. I:

• updated the documentation.
• created a public and a private version of the BlockPopover component.
• updated all the imports to ensure that the private version is used.

Let me know if I missed something! Thanks for the help!

[github-actions]

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: gigitux <[email protected]>
Co-authored-by: youknowriad <[email protected]>
Co-authored-by: noisysocks <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

[youknowriad]

That looks good to me. I'd appreciate a second opinion @WordPress/gutenberg-core

[noisysocks]

It's a useful component that I reach for a lot e.g. when building UIs for block supports. I imagine making it public might make it possible to build more advanced design tooling in plugins which is great. So I'm a 👍.

Before making it public let's be sure to check that there are no APIs (props, etc.) that we want to clean up first.

[gigitux]

Dev Note: BlockPopover Component Public

The BlockPopover component is now publicly accessible. For more details, you can check the README.