Add visible close button to inserter sidebar #61426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
scruffian
reviewed
May 7, 2024
| display: flex; | ||
| justify-content: flex-end; | ||
| z-index: 2; |
There was a problem hiding this comment.
Should we use the z-index mixin?
jeryj
commented
May 7, 2024
| @@ -135,6 +136,7 @@ $block-inserter-tabs-height: 44px; | |||
| flex-grow: 1; | |||
| flex-direction: column; | |||
| overflow-y: auto; | |||
| border-top: $border-width solid $gray-300; | |||
There was a problem hiding this comment.
Moves the border from the tablist to the content so it is still full width
Comment on lines
+52
to
+56
| className="editor-inserter-sidebar__close-button" | ||
| icon={ closeSmall } | ||
| label={ __( 'Close block inserter' ) } | ||
| onClick={ () => setIsInserterOpened( false ) } | ||
| size="small" |
There was a problem hiding this comment.
Match the list view button size
| } | ||
|
|
||
| .editor-inserter-sidebar__content { | ||
| // Leave space for the close button | ||
| height: calc(100% - #{$button-size} - #{$grid-unit-10}); |
There was a problem hiding this comment.
No longer necessary because the close button can sit next to the tabs rather than above them.
|
Size Change: -100 B (-0.01%) Total Size: 1.74 MB
ℹ️ View Unchanged
|
|
This has some issues we should revert. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #61421 so we don't need to prop drill an
onClosefor the sidebar into the<InserterTabs />What?
Add a close button to the inserter.
Why?
We'd like to leave the inserter always open, which means it needs a close button - see #60391.
How?
Absolutely positions the close button and reduces the width of the tablist to make room.
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast