-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update 3rd party actions within composite action. #61211
Conversation
This updates the 3rd party actions used within the `setup-node` composite action. Unfortunately, it seems that Dependabot does not currently update workflows found outside of the `.github/workflows` directory, so these have fallen out of date.
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Flaky tests detected in 3c3923f. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/8883214740
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
After creating this PR, a new feature was announced as public beta where you can specify multiple directories for a package ecosystem. It's unclear if this would solve the problem addressed here. Some more testing is needed. Let's merge this for now and try that out separately! |
Heads up that the Windows version of this CI task is failing for me, not sure if due to this change though: https://github.com/WordPress/gutenberg/actions/runs/8908331640/job/24463757246?pr=61138 |
This seems related: npm/cli#7308 |
It looks like your PR is the first one making a change to the There are some similar (though not exact) reports in the actions/setup-node repo. I did not see anything obvious looking at the release log there. Though the most recent version (4.0.2) did add support for I tried rolling that back in a test PR and it worked for me: https://github.com/WordPress/gutenberg/actions/runs/8911422697. I've gone and created #61289 to apply this change. |
What?
This updates the 3rd party actions used within the
setup-node
composite action. Unfortunately, it seems that Dependabot does not currently update workflows found outside of the.github/workflows
directory, so these have fallen out of date.