Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change TftSpiBase displays to use SpiBus.Write instead of Exchange #1122

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

HakanL
Copy link

@HakanL HakanL commented Feb 13, 2025

Fix for WildernessLabs/Meadow_Issues#826

Also changed API for ST7789 to have the reset pin optional (nullable) (it is optional when driving the display, so it should be nullable IMO)

Changed API for ST7789 to have the reset pin optional
@HakanL
Copy link
Author

HakanL commented Feb 14, 2025

@ctacke what is your take on the proper way to do SpiBus.Exchange on a FT232H? It seems risky to have a spinning loop expecting data to be queued up after the full read is completed, the purpose of Exchange on SPI is to do a concurrent write and read. Also questionable if a large write (the display I'm testing with, ST7789, is sending 48k for a full update) would even have that much available space for a read queue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants