SimpleOffsetPaginator fix and Json Selector #59
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
This is my first contribution so please give me feedback.
I was attempting to use the new SimpleOffsetPaginator implemented here #48. I encountered a bug in
streams.py
as thepagination_page_size
was not being properly set, so I was unable to specify a different value other than25
. I believe this issue was introduced when trying to fix a different issue in #52I have also added the ability to select the records in the request, to enable counting of nested records.
My API was returning records like the example I gave in the readme which gave me a count of
2
no mater how many records are in thecontacts
list.No I can specify
pagination_page_size = 1
andoffset_records_jsonpath = "$.contacts"
to compare the correct number of records.I added the optional argument
offset_records_jsonpath
to both top-level and stream level options.