One line fix for building on OS X #43
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This was the only change I had to make as well. Thanks! |
|
👍 Fixed the build for me as well. |
kevingranade
pushed a commit
to kevingranade/Cataclysm
that referenced
this pull request
Feb 20, 2013
Fix NPC teaching
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apple ships a very old GCC (4.2). This one line change (const ref in npc_opinion constructor) is the only thing I needed to change for simply typing "make" to build a working executable on OS X using the stock GCC. (I may have necessary libraries, like curses, installed via homebrew, I didn't even check any dependencies, it just worked)