-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moon phase checking bugfix #42
Open
michael-s-crouch
wants to merge
58
commits into
Whales:master
Choose a base branch
from
michael-s-crouch:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* The game no longer crashes if you go to the Preset Character menu with no preset characters made, then hit "Enter" * Scrolling a long list of preset characters no longer leaves the last two elements unchanged * The game correctly erases the "No templates found!" message
…s above 6 always returned 0 price).
…l interruptions).
The main bug behind this request (moon phase) has been fixed in master. Between that and the request's size, it's probably safe to close this. |
Conflicts: Makefile disease.h game.cpp itypedef.cpp iuse.cpp mapgen.cpp monster.cpp player.cpp
…nitely equipping styles
kevingranade
pushed a commit
to kevingranade/Cataclysm
that referenced
this pull request
Feb 20, 2013
Add launcher for Linux/OS X users to double click
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! I was impressed by how fast you worked on the bug I reported on the forums (burning to death while crafting) and I started taking a look at the code. This is my first time using git for collaboration, I hope I'm doing this right. I started with a really simple fix -- the code for moon phases was setting the moon to half-full every time, instead of checking the phase.