-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI enhancements #34
Open
tung
wants to merge
14
commits into
Whales:master
Choose a base branch
from
tung:ui-changes
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
UI enhancements #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This gets rid of e.g. "You don't have item ' '!" when pressing space to dismiss an inventory prompt.
Bonus: Tell player they picked up several items when they do.
Bonus: Last selected single item gets highlighted in the multipickup item list.
To try this out, add my repo as a remote:
Fetch the branch for these enhancements:
Then you can check it out on a local branch, which you can call whatever you like:
If you like it, you can merge it in, which automatically closes this pull request. If not, post here and I can change things. |
kevingranade
pushed a commit
to kevingranade/Cataclysm
that referenced
this pull request
Feb 20, 2013
caching game::light_level().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've made a number of enhancements, mostly related to multipickup and multidrop.
Multipickup (examine)
Multidrop
I use a loop instead of multiplication to calculate weight and volume for stacks, since that's the way it's done in player.cpp. Is this an oversight, or is it meant to be done this way?
Look around
Monster list
Other