Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature/ROFO-184] 종합랭킹 #79

Merged
merged 22 commits into from
Sep 14, 2024
Merged

[Feature/ROFO-184] 종합랭킹 #79

merged 22 commits into from
Sep 14, 2024

Conversation

hyunjungkimm
Copy link
Contributor

@hyunjungkimm hyunjungkimm commented Sep 10, 2024 •
edited
Loading

개요

  • 종합랭킹을 구현하였습니다.
  • 종합랭킹 조회 api 개발하였습니다.

변경사항

  • 종합랭킹 스케줄링
  • 종합랭킹 조회 api

테스트

  • 테스트 코드 추가여부 O

관련 지라 및 위키 링크

리뷰어에게 하고 싶은 말

  • �ROFO-183 티켓에서 fallback 함수 중복 실행 관련 코멘트 받은게 있어서 데이터가 없을 경우에는 예외 발생하고 비동기로 실행하여 락을 걸어 저장하도록 변경했었습니다. 참고

+) 로컬 build할때는 에러가 안나는데 github action에서는 에러가 나서 확인 후 수정하겠습니다~!

  • COALESCE함수에서 값을 치환하는 과정에서 DataIntegrityViolationException 발생하는데 원인을 알아보려고 했지만... 정확하게 왜 발생하는지는 모르겠습니다..ㅠㅠㅠ jdsl에서 제공하는 coalesce 함수를 사용할때는 github action에서도 제대로 동작해서 수정하였습니다!

@hyunjungkimm hyunjungkimm reopened this Sep 10, 2024
@hyunjungkimm hyunjungkimm self-assigned this Sep 10, 2024
@hyunjungkimm hyunjungkimm added the enhancement New feature or request label Sep 10, 2024
@hyunjungkimm hyunjungkimm reopened this Sep 12, 2024
konempty
konempty reviewed Sep 12, 2024
View reviewed changes
Copy link
Contributor

@konempty konempty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다 👍 👍
코멘트 2개 남겼는데 답변 부탁드리겠습니다~!

src/main/kotlin/kr/weit/roadyfoody/review/repository/FoodSpotsReviewRepository.kt Outdated Show resolved Hide resolved
src/test/kotlin/kr/weit/roadyfoody/ranking/application/service/RankingQueryServiceTest.kt Outdated Show resolved Hide resolved
@konempty
Copy link
Contributor

테스트가 깨져있군요 ㅠㅠ

@hyunjungkimm
Copy link
Contributor Author

@konempty 테스트 깨지는것 수정했습니다!

lin-chae
lin-chae approved these changes Sep 13, 2024
View reviewed changes
Copy link
Contributor

@lin-chae lin-chae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다! 😀 👍

src/main/kotlin/kr/weit/roadyfoody/review/repository/FoodSpotsReviewRepository.kt Show resolved Hide resolved
konempty
konempty approved these changes Sep 13, 2024
View reviewed changes
Copy link
Contributor

@konempty konempty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다 👍 👍
코멘트 몇개 남겼는데 확인 부탁드립니다~!

src/main/kotlin/kr/weit/roadyfoody/review/repository/FoodSpotsReviewRepository.kt Show resolved Hide resolved
src/test/kotlin/kr/weit/roadyfoody/ranking/application/service/RankingQueryServiceTest.kt Outdated Show resolved Hide resolved
Unagi-zoso
Unagi-zoso approved these changes Sep 13, 2024
View reviewed changes
Copy link
Contributor

@Unagi-zoso Unagi-zoso left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다! 👍 잘 작성해주셨네요!
테스트 코드 관련해 개인적인 의견을 조금 적어봤습니다!

Github Actions 테스트 깨지는 것도 잘 해결하셨네요. 존경스럽습니다.
도대체 뭐가 문제였을까요..

src/test/kotlin/kr/weit/roadyfoody/ranking/application/service/RankingCommandServiceTest.kt Show resolved Hide resolved
src/test/kotlin/kr/weit/roadyfoody/ranking/application/service/RankingQueryServiceTest.kt Show resolved Hide resolved
@hyunjungkimm hyunjungkimm merged commit 31e78cd into develop Sep 14, 2024
1 check passed
@hyunjungkimm hyunjungkimm deleted the feature/ROFO-184 branch September 14, 2024 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@konempty konempty konempty approved these changes

@Unagi-zoso Unagi-zoso Unagi-zoso approved these changes

@lin-chae lin-chae lin-chae approved these changes

Assignees

@hyunjungkimm hyunjungkimm

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hyunjungkimm @konempty @Unagi-zoso @lin-chae