feat: more tests for alias support

WeihanLi · Nov 24, 2024 · ca96adb · ca96adb
1 parent 31019b0
commit ca96adb
Show file tree

Hide file tree

Showing 5 changed files with 26 additions and 9 deletions.
diff --git a/src/dotnet-exec/Commands/AliasCommand.cs b/src/dotnet-exec/Commands/AliasCommand.cs
@@ -10,14 +10,15 @@ internal sealed class AliasCommand : Command
     public AliasCommand() : base("alias", "Alias management")
     {
         AddCommand(new AliasListCommand());
+        AddCommand(new AliasSetCommand());
+        AddCommand(new AliasUnsetCommand());
     }
 }
 
 file sealed class AliasListCommand : Command
 {
     public AliasListCommand() : base("list", "List all alias config")
     {
-        AddArgument(AliasCommand.AliasNameArg);
     }
 }
 

diff --git a/src/dotnet-exec/Contracts/AppConfiguration.cs b/src/dotnet-exec/Contracts/AppConfiguration.cs
@@ -9,7 +9,7 @@ public sealed class AppConfiguration
     // theme settings ...
     public Dictionary<string, string> Aliases { get; set; } = new()
     {
-        { "new-guid", "System.Guid.NewGuid()" },
+        { "guid", "System.Guid.NewGuid()" },
         { "now", "System.DateTimeOffset.Now" },
         { "date", "System.DateTimeOffset.Now" },
     };

diff --git a/src/dotnet-exec/Helper.cs b/src/dotnet-exec/Helper.cs
@@ -234,15 +234,14 @@ public static void Initialize(this Command command, IServiceProvider serviceProv
                             "set" => async (InvocationContext context) =>
                             {
                                 var aliasName = context.ParseResult.GetValueForArgument(AliasCommand.AliasNameArg);
-
-                                if (IsValidAliasName(aliasName))
+                                if (!IsValidAliasName(aliasName))
                                 {
-                                    Console.WriteLine("Invalid alias name, alias name max length is  64 and only allow characters,numbers and `-`/`_`/`:`/`.` ");
+                                    Console.WriteLine("Invalid alias name, alias name max length is 64 and only allow characters,numbers and `-`/`_`/`:`/`.` ");
                                     return;
                                 }
 
                                 var aliasValue = context.ParseResult.GetValueForArgument(AliasCommand.AliasValueArg);
-                                if (!appConfiguration.Aliases.TryGetValue(aliasName, out var currentValue) || currentValue == aliasValue)
+                                if (appConfiguration.Aliases.TryGetValue(aliasName, out var currentValue) && currentValue == aliasValue)
                                 {
                                     return;
                                 }
@@ -268,6 +267,7 @@ public static void Initialize(this Command command, IServiceProvider serviceProv
                                 return Task.CompletedTask;
                             }
                         };
+                        aliasSubCommand.SetHandler(aliasCommandHandler);
                     }
                     break;
             }

diff --git a/src/dotnet-exec/Properties/launchSettings.json b/src/dotnet-exec/Properties/launchSettings.json
@@ -68,7 +68,22 @@
     "alias-test": {
       "commandName": "Project",
       "targetFramework": "net8.0",
-      "commandLineArgs": "new-guid"
+      "commandLineArgs": "date"
+    },
+    "alias-list": {
+      "commandName": "Project",
+      "targetFramework": "net8.0",
+      "commandLineArgs": "alias list"
+    },
+    "alias-set": {
+      "commandName": "Project",
+      "targetFramework": "net8.0",
+      "commandLineArgs": "alias set guid \"Guid.NewGuid()\""
+    },
+    "alias-unset": {
+      "commandName": "Project",
+      "targetFramework": "net8.0",
+      "commandLineArgs": "alias unset guid"
     }
   }
 }
diff --git a/src/dotnet-exec/Services/LocalAppConfigSource.cs b/src/dotnet-exec/Services/LocalAppConfigSource.cs
@@ -40,8 +40,9 @@ public async Task<bool> SaveConfigAsync(AppConfiguration appConfig)
             Helper.EnsureFolderCreated(folder);
         }
 
-        using var fs = File.OpenWrite(DefaultConfigPath);
-        await JsonSerializer.SerializeAsync(fs, appConfig, JsonHelper.UnsafeEncoderOptions);
+        var bytes = JsonSerializer.SerializeToUtf8Bytes(appConfig, JsonHelper.UnsafeEncoderOptions);
+        await File.WriteAllBytesAsync(DefaultConfigPath, bytes);
+
         return true;
     }
 }