Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Russian references #4

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix Russian references #4

wants to merge 1 commit into from

Conversation

jvamvas
Copy link

@jvamvas jvamvas commented Feb 1, 2022

The file references-ru.json is currently a duplicate of the English references file.

This PR replaces adds the actual references, which have been extracted from the original XML file at https://gitlab.com/shimorina/webnlg-dataset/-/blob/master/release_v3.0/ru/test/rdf-to-text-generation-test-data-with-refs-ru.xml.

@Shimorina
Copy link
Member

Hi!

Thank you for the PR!

I would propose not to use the test set because that would increase its overuse by researchers. Feel free to submit the dev part instead.

Many thanks

@jvamvas
Copy link
Author

jvamvas commented Feb 7, 2022

Thank you for the response! 🙂
In that case I think the reference files should be removed altogether. Other people might be confused by the faulty reference file (like I was).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants