-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[view-transitions] Implement view-transition-name: match-element
#35953
[view-transitions] Implement view-transition-name: match-element
#35953
Conversation
EWS run on previous version of this PR (hash c1d02ff)
|
c1d02ff
to
9734fe9
Compare
EWS run on previous version of this PR (hash 9734fe9)
|
9734fe9
to
d00d9bb
Compare
EWS run on previous version of this PR (hash d00d9bb) |
@nt1m FYI, I've imported your tests directly to the chromium CL: https://chromium-review.googlesource.com/c/chromium/src/+/6105953. Thanks! |
@noamr Just a heads up you don't need the |
d00d9bb
to
a742135
Compare
EWS run on current version of this PR (hash a742135) |
Failed mac-AS-debug-wk2 checks. Please resolve failures and re-apply Rejecting #35953 from merge queue. |
Safe-Merge-Queue: Build #41790. |
https://bugs.webkit.org/show_bug.cgi?id=282344 rdar://138932551 Reviewed by Matt Woodrow. See w3c/csswg-drafts#10995 (comment) * LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/match-element-name-expected.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/match-element-name.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/parsing/view-transition-name-valid-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/parsing/view-transition-name-valid.html: * Source/WebCore/css/CSSProperties.json: * Source/WebCore/css/CSSValueKeywords.in: * Source/WebCore/dom/ViewTransition.cpp: (WebCore::effectiveViewTransitionName): * Source/WebCore/rendering/style/ViewTransitionName.h: (WebCore::Style::ViewTransitionName::createWithMatchElement): (WebCore::Style::ViewTransitionName::isMatchElement const): (WebCore::Style::ViewTransitionName::scopeOrdinal const): (WebCore::Style::operator<<): * Source/WebCore/style/StyleBuilderConverter.h: (WebCore::Style::BuilderConverter::convertViewTransitionName): Canonical link: https://commits.webkit.org/288102@main
a742135
to
b9fbc53
Compare
Committed 288102@main (b9fbc53): https://commits.webkit.org/288102@main Reviewed commits have been landed. Closing PR #35953 and removing active labels. |
b9fbc53
a742135