Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[view-transitions] Implement view-transition-name: match-element #35953

Conversation

nt1m
Copy link
Member

@nt1m nt1m commented Oct 30, 2024

b9fbc53

[view-transitions] Implement `view-transition-name: match-element`
https://bugs.webkit.org/show_bug.cgi?id=282344
rdar://138932551

Reviewed by Matt Woodrow.

See w3c/csswg-drafts#10995 (comment)

* LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/match-element-name-expected.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/match-element-name.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/parsing/view-transition-name-valid-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/parsing/view-transition-name-valid.html:
* Source/WebCore/css/CSSProperties.json:
* Source/WebCore/css/CSSValueKeywords.in:
* Source/WebCore/dom/ViewTransition.cpp:
(WebCore::effectiveViewTransitionName):
* Source/WebCore/rendering/style/ViewTransitionName.h:
(WebCore::Style::ViewTransitionName::createWithMatchElement):
(WebCore::Style::ViewTransitionName::isMatchElement const):
(WebCore::Style::ViewTransitionName::scopeOrdinal const):
(WebCore::Style::operator<<):
* Source/WebCore/style/StyleBuilderConverter.h:
(WebCore::Style::BuilderConverter::convertViewTransitionName):

Canonical link: https://commits.webkit.org/288102@main

a742135

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ✅ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ❌ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2
✅ 🛠 🧪 unsafe-merge ✅ 🛠 tv ✅ 🛠 mac-safer-cpp
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@nt1m nt1m requested review from rniwa and cdumez as code owners October 30, 2024 18:46
@nt1m nt1m self-assigned this Oct 30, 2024
@nt1m nt1m added the CSS Cascading Style Sheets implementation label Oct 30, 2024
@nt1m nt1m force-pushed the eng/view-transitions-Implement-view-transition-name-match-element branch from c1d02ff to 9734fe9 Compare October 30, 2024 19:03
@nt1m nt1m requested a review from mattwoodrow October 30, 2024 19:03
@nt1m nt1m force-pushed the eng/view-transitions-Implement-view-transition-name-match-element branch from 9734fe9 to d00d9bb Compare October 30, 2024 19:06
@noamr
Copy link
Contributor

noamr commented Dec 18, 2024

@nt1m FYI, I've imported your tests directly to the chromium CL: https://chromium-review.googlesource.com/c/chromium/src/+/6105953. Thanks!
Spec PR is up now after the resolution: w3c/csswg-drafts#11393

@nt1m
Copy link
Member Author

nt1m commented Dec 18, 2024

@noamr Just a heads up you don't need the -expected.html file in your CL, it's only for WebKit. The test file should reuse the auto ref in Chromium.

@nt1m nt1m force-pushed the eng/view-transitions-Implement-view-transition-name-match-element branch from d00d9bb to a742135 Compare December 19, 2024 00:06
@nt1m nt1m added the safe-merge-queue Applied to automatically send a pull-request to merge-queue after passing EWS checks label Dec 19, 2024
@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Dec 19, 2024
@webkit-ews-buildbot
Copy link
Collaborator

Failed mac-AS-debug-wk2 checks. Please resolve failures and re-apply safe-merge-queue label.

Rejecting #35953 from merge queue.

@webkit-ews-buildbot webkit-ews-buildbot removed the safe-merge-queue Applied to automatically send a pull-request to merge-queue after passing EWS checks label Dec 19, 2024
@webkit-ews-buildbot
Copy link
Collaborator

Safe-Merge-Queue: Build #41790.

@nt1m nt1m added unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing and removed merging-blocked Applied to prevent a change from being merged labels Dec 19, 2024
https://bugs.webkit.org/show_bug.cgi?id=282344
rdar://138932551

Reviewed by Matt Woodrow.

See w3c/csswg-drafts#10995 (comment)

* LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/match-element-name-expected.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/match-element-name.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/parsing/view-transition-name-valid-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/parsing/view-transition-name-valid.html:
* Source/WebCore/css/CSSProperties.json:
* Source/WebCore/css/CSSValueKeywords.in:
* Source/WebCore/dom/ViewTransition.cpp:
(WebCore::effectiveViewTransitionName):
* Source/WebCore/rendering/style/ViewTransitionName.h:
(WebCore::Style::ViewTransitionName::createWithMatchElement):
(WebCore::Style::ViewTransitionName::isMatchElement const):
(WebCore::Style::ViewTransitionName::scopeOrdinal const):
(WebCore::Style::operator<<):
* Source/WebCore/style/StyleBuilderConverter.h:
(WebCore::Style::BuilderConverter::convertViewTransitionName):

Canonical link: https://commits.webkit.org/288102@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/view-transitions-Implement-view-transition-name-match-element branch from a742135 to b9fbc53 Compare December 19, 2024 18:46
@webkit-commit-queue
Copy link
Collaborator

Committed 288102@main (b9fbc53): https://commits.webkit.org/288102@main

Reviewed commits have been landed. Closing PR #35953 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit b9fbc53 into WebKit:main Dec 19, 2024
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Dec 19, 2024
@nt1m nt1m deleted the eng/view-transitions-Implement-view-transition-name-match-element branch December 19, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CSS Cascading Style Sheets implementation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants