[NFC] Fix note about manually generated test output #7221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The note mentioned update_lit_checks.py in the first line, which made update_lit_checks.py think that it _should_ update the test output, even though the comment was explicitly about how it should not update the test output. Reword the comment to avoid the problem.
kripken
approved these changes
Jan 15, 2025
|
Good idea, done. (At least, to the extent that it wouldn't become more complicated.) |
kripken
approved these changes
Jan 15, 2025
dschuff
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The note mentioned update_lit_checks.py in the first line, which made
update_lit_checks.py think that it should update the test output, even
though the comment was explicitly about how it should not update the
test output. Reword the comment to avoid the problem.
Also make the check in the update script stricter for good measure.