Also remove BulkMemory feature when running LLVMMemCopyFillLowering

[dschuff]

This is safe because we have already asserted that there are no passive segments. This causes Binaryen to encode the resulting binary without a DataCount section, making it compatible with engines that don't support bulk memory.

[dschuff]

@kripken / @tlively we don't currently have tests that check the output features of the module, or of the binary. Any suggestions on how best to do this?

[kripken]

If you add --emit-target-features then it emits the features section, and we print that in the output, so it can be detected there. e.g.

$ bin/wasm-opt --emit-target-features test/hello_world.wat --enable-simd --print
(module
 (type $i32_i32_=>_i32 (func (param i32 i32) (result i32)))
 (memory $0 256 256)
 (export "add" (func $add))
 (func $add (param $x i32) (param $y i32) (result i32)
  (i32.add
   (local.get $x)
   (local.get $y)
  )
 )
 ;; features section: mutable-globals, simd, sign-ext
)

That shows the default enabled features + simd that was manually enabled.

If that can't work for some reason, another option is test/unit/test_features.py

[dschuff]

Ah, great! I'll do that.
One small issue is that update_lit_checks.py doesn't support updating this test because it ignores the comment that comes after all the semantic module items. I adjusted the comment to reflect that.

[kripken]

Another option might be a separate small test for the features section, which would allow the main test to still be auto-updateable, but I don't feel strongly.