Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GC][Threads] Atomic GC operations require --enable-threads #7185

Merged
merged 2 commits into from
Jan 6, 2025
Merged

[GC][Threads] Atomic GC operations require --enable-threads #7185

merged 2 commits into from
Jan 6, 2025

Conversation

kripken
Copy link
Member

@kripken kripken commented Jan 2, 2025

Without this, it is invalid to lower them to simpler atomic operations like
atomic.fence (as some passes do) or linear memory atomics (as a future
lowering pass might do).

Fixes #7184

tlively
tlively approved these changes Jan 6, 2025
View reviewed changes
Copy link
Member

@tlively tlively left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@kripken kripken merged commit fcea593 into WebAssembly:main Jan 6, 2025
13 checks passed
@kripken kripken deleted the atomic.gc.feature branch January 6, 2025 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tlively tlively tlively approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GC+atomics and features
2 participants
@kripken @tlively