Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#7178] Introduce guard arround local get/set generation #7180

Closed
wants to merge 2 commits into from

Conversation

mtb0x1
Copy link
Contributor

@mtb0x1 mtb0x1 commented Dec 26, 2024

This is an attempt fix of issue #7178 , This PR needs (?) a regression test. (I wasn't able to reproduce a wast file to trigger the issue).

@mtb0x1 mtb0x1 marked this pull request as draft December 26, 2024 15:21
@famasoon
Copy link

If there's any information I should provide, please let me know! I'll share it.

@mtb0x1
Copy link
Contributor Author

mtb0x1 commented Dec 27, 2024

If there's any information I should provide, please let me know! I'll share it.

if you can confirm the test result using this PR, you should have an error message instead of a Seg. fault.

@famasoon
Copy link

Thank you for checking!
I think adding it to the pull request might cause information to get mixed up, so I'll write the details in the Issue instead.

@famasoon
Copy link

I've written the details in the Issue. The crash no longer occurs!

@kripken
Copy link
Member

kripken commented Dec 30, 2024

Thanks for the PR @mtb0x1 !

Sorry, I just saw that this fixes the issue now after already opening #7183 If you want I can close that one and we can continue here, but it does add testing, and a few other things that I would have asked as changes in this PR.

@mtb0x1
Copy link
Contributor Author

mtb0x1 commented Dec 30, 2024

Thanks for the PR @mtb0x1 !

Sorry, I just saw that this fixes the issue now after already opening #7183 If you want I can close that one and we can continue here, but it does add testing, and a few other things that I would have asked as changes in this PR.

no problem, I will close this one.

@mtb0x1 mtb0x1 closed this Dec 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants