Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: removes redundant clientId() call during subscriber init #5623

Merged
merged 2 commits into from
Jan 29, 2025

Conversation

ganchoradkov
Copy link
Member

@ganchoradkov ganchoradkov commented Jan 29, 2025

Description

Removed redundant setting of clientId during subscriber init. The value is still used and required to set subscription IDs but should be fetched when needed instead of during init. This change also has the benefit of speeding up the sdk init

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Draft PR (breaking/non-breaking change which needs more work for having a proper functionality [Mark this PR as ready to review only when completely ready])
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How has this been tested?

tests

Checklist

  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

Additional Information (Optional)

Please include any additional information that may be useful for the reviewer.

@arein arein added the accepted label Jan 29, 2025
@ganchoradkov ganchoradkov changed the title chore: removes clientId set on subscriber init and assigns it only wh… chore: removes redundant clientId() call during subscriber init Jan 29, 2025
@ganchoradkov ganchoradkov marked this pull request as ready for review January 29, 2025 11:26
Copy link
Contributor

@Cali93 Cali93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

packages/core/src/controllers/subscriber.ts Outdated Show resolved Hide resolved
@ganchoradkov ganchoradkov merged commit 91ea6a8 into v2.0 Jan 29, 2025
8 checks passed
@ganchoradkov ganchoradkov deleted the chore/init-latency branch January 29, 2025 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants