Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: repo cleanup #5611

Merged
merged 3 commits into from
Jan 27, 2025
Merged

chore: repo cleanup #5611

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
64fde8c
chore: repo cleanup
ganchoradkov Jan 24, 2025
b010878
chore: rm web3wallet from pr checks
ganchoradkov Jan 24, 2025
7cb1381
chore: optimises lodash import
ganchoradkov Jan 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions .github/workflows/pr_checks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@ jobs:
packages/sign-client/dist
packages/types/dist
packages/utils/dist
packages/web3wallet/dist
providers/ethereum-provider/dist
providers/signer-connection/dist
providers/universal-provider/dist
Expand Down Expand Up @@ -65,7 +64,6 @@ jobs:
test-prefix:
- packages/sign-client
- packages/core
- packages/web3wallet
- packages/utils
- providers/universal-provider
- providers/ethereum-provider
Expand Down
5 changes: 4 additions & 1 deletion .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,4 +64,7 @@ DerivedData
*.hmap
*.ipa
*.xcuserstate
project.xcworkspace
project.xcworkspace

## web3wallet dependencies since its deprecated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this do anything after the file's already been tracked?

it doesn't AFAIR

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is no tracked package-lock.json for web3wallet at the moment and this ignore is preemptive

packages/web3wallet/package-lock.json
10 changes: 6 additions & 4 deletions lerna.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,10 @@
{
"npmClient": "npm",
"packages": [
"packages/*",
"providers/*"
],
"packages": ["packages/*", "providers/*"],
"command": {
"run": {
"ignore": ["packages/web3wallet"]
}
},
"version": "2.17.5"
}
50,140 changes: 15,981 additions & 34,159 deletions package-lock.json
View file
Open in desktop

Large diffs are not rendered by default.

1 change: 0 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@
"packages/utils",
"packages/core",
"packages/sign-client",
"packages/web3wallet",
"packages/react-native-compat",
"providers/universal-provider",
"providers/signer-connection",
Expand Down
2 changes: 1 addition & 1 deletion packages/core/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@
"@walletconnect/keyvaluestorage": "1.1.1",
"@walletconnect/logger": "2.1.2",
"@walletconnect/relay-api": "1.0.11",
"@walletconnect/relay-auth": "1.0.4-canary-bnl-1",
"@walletconnect/relay-auth": "1.1.0",
"@walletconnect/safe-json": "1.0.2",
"@walletconnect/time": "1.0.2",
"@walletconnect/types": "2.17.5",
Expand Down
5 changes: 1 addition & 4 deletions packages/sign-client/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,9 +49,6 @@
"events": "3.3.0"
},
"devDependencies": {
"@aws-sdk/client-cloudwatch": "3.450.0",
"@walletconnect/jsonrpc-provider": "1.0.14",
"@walletconnect/jsonrpc-ws-connection": "1.0.14",
"@walletconnect/relay-api": "1.0.11"
"@aws-sdk/client-cloudwatch": "3.450.0"
}
}
1 change: 0 additions & 1 deletion packages/sign-client/test/shared/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
export * from "./connect";
export * from "./init";
export * from "./mock";
export * from "./values";
export * from "./helpers";
export * from "./metrics";
Expand Down
137 changes: 0 additions & 137 deletions packages/sign-client/test/shared/mock.ts
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion packages/utils/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
"@walletconnect/jsonrpc-utils": "1.0.8",
"@walletconnect/keyvaluestorage": "1.1.1",
"@walletconnect/relay-api": "1.0.11",
"@walletconnect/relay-auth": "1.0.4-canary-bnl-1",
"@walletconnect/relay-auth": "1.1.0",
"@walletconnect/safe-json": "1.0.2",
"@walletconnect/time": "1.0.2",
"@walletconnect/types": "2.17.5",
Expand Down
2 changes: 1 addition & 1 deletion providers/universal-provider/src/utils/misc.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import {
} from "@walletconnect/utils";
import { RPC_URL } from "../constants";
import { Namespace, NamespaceConfig } from "../types";
import { merge } from "lodash";
import merge from "lodash/merge";

export function getRpcUrl(chainId: string, rpc: Namespace, projectId?: string): string | undefined {
const chain = parseChainId(chainId);
Expand Down
Loading