Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: adds deprecation notice on pairing methods and reduces expiry … #5582

Merged
merged 6 commits into from
Jan 17, 2025

Conversation

ganchoradkov
Copy link
Member

@ganchoradkov ganchoradkov commented Jan 8, 2025

Description

Supersedes #5310

  • Added deprecation warnings on pairings methods
  • Reduced expiry of activated pairings to five minutes instead of thirty days essentially removing stale pairings without introing breaking changes

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Draft PR (breaking/non-breaking change which needs more work for having a proper functionality [Mark this PR as ready to review only when completely ready])
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How has this been tested?

  • addtional tests to confirm the new behaviour
  • the old tests to confirm no breaking changes

Checklist

  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

Additional Information (Optional)

Please include any additional information that may be useful for the reviewer.

@ganchoradkov ganchoradkov requested a review from Cali93 January 8, 2025 09:19
@ganchoradkov ganchoradkov self-assigned this Jan 8, 2025
@arein arein added the accepted label Jan 8, 2025
Copy link
Contributor

@Cali93 Cali93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have docs where we can point folks to for more context on the deprecation ?

@ganchoradkov
Copy link
Member Author

Do we have docs where we can point folks to for more context on the deprecation ?
Not yet, these are obscure behaviours that are not really documented

Copy link
Contributor

@devceline devceline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ganchoradkov ganchoradkov merged commit c932adc into v2.0 Jan 17, 2025
9 checks passed
@ganchoradkov ganchoradkov deleted the chore/pairing-methods-deprecation-notice branch January 17, 2025 13:04
@ganchoradkov ganchoradkov mentioned this pull request Jan 21, 2025
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants