Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 1ca tests flakiness #5514

Merged
merged 2 commits into from
Nov 29, 2024
Merged

Conversation

ganchoradkov
Copy link
Member

Description

Implemented cache result in createDelayedPromise util so once the promise resolves, it will return the cached result when called again. This solves 1CA tests flakiness as calling resolve after it was already resolved was causing the tests to hang

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Draft PR (breaking/non-breaking change which needs more work for having a proper functionality [Mark this PR as ready to review only when completely ready])
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How has this been tested?

tests

Checklist

  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

Additional Information (Optional)

Please include any additional information that may be useful for the reviewer.

@arein arein added the accepted label Nov 22, 2024
@ganchoradkov ganchoradkov changed the base branch from v2.0 to fix/single-connection November 29, 2024 11:46
@ganchoradkov ganchoradkov merged commit 2040a43 into fix/single-connection Nov 29, 2024
13 checks passed
@ganchoradkov ganchoradkov deleted the fix/1ca-test-flakiness branch November 29, 2024 11:46
@ganchoradkov ganchoradkov mentioned this pull request Dec 13, 2024
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants