feat: provider request set custom expiry #4119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 10, 2024 09:41
ganchoradkov
commented
Jan 10, 2024
| @@ -48,7 +48,7 @@ describe("EthereumProvider", function () { | |||
| qrModalOptions: { | |||
| themeMode: "dark", | |||
| themeVariables: { | |||
| "--w3m-z-index": "99", | |||
| "--wcm-z-index": "99", | |||
There was a problem hiding this comment.
this was left over from when we updated the wcm types, resolving it so ts is satisfied
bkrem
approved these changes
Jan 10, 2024
20 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added the ability to set custom request expiry when using the providers. The custom expiry was already supported by
sign-clientso only needed to pass down the argumentsType of change
How has this been tested?
tests
Checklist