Merge pull request #4573 from WalletConnect/fix/error-msg-on-metadata…

…-validation fix: url validation message
WalletConnect · May 29, 2024 · c1751c0 · c1751c0
2 parents 8c447a9 + c21a7d5
commit c1751c0
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 1 deletion.
diff --git a/packages/sign-client/src/client.ts b/packages/sign-client/src/client.ts
@@ -71,7 +71,7 @@ export class SignClient extends ISignClient {
       throw new Error("description is required value in metadata");
     }
     if (!metadata.url) {
-      throw new Error("description is required value in metadata");
+      throw new Error("url is required value in metadata");
     }
   }
 

diff --git a/packages/sign-client/test/sdk/client.spec.ts b/packages/sign-client/test/sdk/client.spec.ts
@@ -66,6 +66,19 @@ describe("Sign Client Integration", () => {
       }),
     ).rejects.toThrowError("description is required value in metadata");
   });
+  it("should not initialize with invalid metadata url", async () => {
+    await expect(
+      SignClient.init({
+        ...TEST_SIGN_CLIENT_OPTIONS,
+        metadata: {
+          ...TEST_INVALID_METADATA,
+          description: "description",
+        },
+        name: "init",
+        signConfig: { disableRequestQueue: true },
+      }),
+    ).rejects.toThrowError("url is required value in metadata");
+  });
 
   describe("connect", () => {
     it("connect (with new pairing)", async () => {