Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for messageId #52

Merged
merged 3 commits into from
May 22, 2022
Merged

add support for messageId #52

merged 3 commits into from
May 22, 2022

Conversation

WaleedAshraf
Copy link
Owner

@WaleedAshraf WaleedAshraf commented May 21, 2022

Breaking:

  • "should" replaced with "must" in the error messages, as per in AJV

New / Improvements:

  • Support AsyncAPI schema v2.4.0
  • Added validateByMessageId() method, which only requires key and value. To use this method, your AsyncAPI schema should be >= 2.4.0. messageId should be defined in schema as per AsyncAPI 2.4.0 schema definition.
  • msgIdentifier option is only required if you use .validate() method.
  • You can use both validateByMessageId() and validate() methods if your AsyncAPI schema version is >= 2.4.0
  • Start using ajv-formats for custom formats.

closes #25, closes #51

@codecov
Copy link

codecov bot commented May 21, 2022

Codecov Report

Merging #52 (87e2013) into master (6c4e01c) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master       #52   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            6         6           
  Lines           98       117   +19     
  Branches        19        30   +11     
=========================================
+ Hits            98       117   +19     

@WaleedAshraf WaleedAshraf merged commit 34ef690 into master May 22, 2022
@WaleedAshraf WaleedAshraf deleted the messageId branch August 5, 2022 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Use ajv-formats to validate data formats Feature: Support for operationId
1 participant