Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(emoji-picker): remove EmojiPicker component #2633

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

stevenpersia
Copy link
Contributor

Eliminate the EmojiPicker component along with its associated files, tests, and documentation to streamline the codebase.

@stevenpersia stevenpersia requested a review from a team as a code owner December 3, 2024 10:10
Copy link

linear bot commented Dec 3, 2024

Copy link

github-actions bot commented Dec 3, 2024

👀 Visit Preview

Copy link
Contributor Author

@stevenpersia stevenpersia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just checking if we need to document this package removal in any changelog/release notes, even though it seems to be an isolated removal of the emoji-picker folder only. The changes look straightforward but want to confirm our documentation process for breaking changes. Any thoughts?

Copy link
Contributor

@cnairi cnairi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @stevenpersia

Could you please also remove the EmojiPicker from:

  • welcome-ui/.github/ISSUE_TEMPLATE/update-request.yml
  • welcome-ui/.github/ISSUE_TEMPLATE/bug-report.yml

Thanks a lot 🙏

@stevenpersia stevenpersia force-pushed the wui-38-deprecate-emojipicker branch from e885b98 to a478fe6 Compare December 9, 2024 13:34
@stevenpersia stevenpersia requested a review from a team as a code owner December 9, 2024 13:34
@stevenpersia
Copy link
Contributor Author

stevenpersia commented Dec 9, 2024

Good catch, thanks @cnairi 🙏 (a478fe6)

@stevenpersia stevenpersia requested a review from cnairi December 11, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants