Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mdk/enhance wlan support #64

Draft
wants to merge 47 commits into
base: dev
Choose a base branch
from
Draft

Mdk/enhance wlan support #64

wants to merge 47 commits into from

Conversation

MichaelKetchel
Copy link
Contributor

Type of change

Pick at least one.

  • Bug fix (non-breaking change that fixes something)
  • Documentation update (readme, changelog, man page, etc.)
  • [ X] New feature (non-breaking change adding functionality)
  • [ X] Breaking change (fix or feature changing existing functionality)
  • [ X ] Code quality improvement (refactor, performance improvements)
  • Other (please specify):

Breaking change

Does this Pull Request introduce a breaking change?
Most wlan api endpoints have been reworked to work in a more canonical REST style.

Proposed change

Massive refactor of WLAN control code

Testing

Please explain how you tested this change manually, and if applicable, what new tests you added.
Tested manually, postman collection attached.

Checklist

  • [X ] I have read the contribution guidelines and policies
  • [X ] I have targeted this PR against the correct git branch
  • [ X] I ran the test suite and verified it succeeded
  • [X ] I linked an approved GitHub issue to this PR (in the next section). No PR without a related GH issue. Conversations about your PR efforts in other channels such as electronic mail, social media, morse code, and WLAN Pi Slack do not count.
  • I have updated the changelog (if applicable)
  • I have added or updated the documentation (if applicable)

Related Issues/PRs

Pick at least one.

Michael Ketchel and others added 24 commits October 25, 2024 15:32
start of runcommand refactor
66fe38f
@MichaelKetchel
Refactored run_command usage and added tests
1f82960
@MichaelKetchel
Refactored runcommand_error.py to use standard values
ea17a88
@MichaelKetchel
Fix tests
9845c78
@MichaelKetchel
Improve command parsing using shlex and add docblocks
b11e18a
@MichaelKetchel
Start a constants file
e578a77
@MichaelKetchel
Add more util methods from other repos, and tests
6cecf23
@MichaelKetchel
Refactor util api to use runcommand
3f28a72
@MichaelKetchel
Refactor subprocess usage out of utils service
b514219
@MichaelKetchel
Refactor subprocess usage out of network service
6e8395c
@MichaelKetchel
heavy-handed pass at consolidating all our global constants into cons…
d46ea8c 
…tants.py
@joshschmelzle
API port hardening release v1.0.5-1 (WLAN-Pi#52)
1f08bd5 
* add error handling when removing iptables rule (WLAN-Pi#51)
Convert bluetooth_service.py
7232d0c
Complete refactoring out of helpers.py
d0f0756
Completed refactoring of subprocess usage
5c76ac2
@MichaelKetchel
Merge branch 'WLAN-Pi:dev' into dev
c6a5b30
Refactor unittests to pytest
fb57c2a
Merge remote-tracking branch 'origin/dev' into dev
e393087
Format Cleanups
ecf9aa1
Remove todo item
0254570
Major refactor of wireless control
ccfbc71
Multiple adapter control should work now.
bf84f1f
More improvements
8cc892b
Formatted and linted
89ae0a4
@MichaelKetchel MichaelKetchel changed the base branch from dev to main November 5, 2024 02:45
@MichaelKetchel MichaelKetchel changed the base branch from main to dev November 5, 2024 02:46
Michael Ketchel added 2 commits November 4, 2024 21:47
Formatted and linted again
00cdf8a
Merge branch 'dev' into mdk/enhance_wlan_support
439fcbc 
# Conflicts:
#	wlanpi_core/services/network_service.py
#	wlanpi_core/utils/general.py
#	wlanpi_core/utils/network.py
Michael Ketchel added 2 commits November 4, 2024 22:01
Formatted and linted again
1b80d9b
fixes WLAN-Pi#14
a91f081 
and some other cleanups and fixes
@MichaelKetchel
Copy link
Contributor Author

Network API.postman_collection.json
Test postman collection

@MichaelKetchel MichaelKetchel marked this pull request as ready for review November 5, 2024 03:23
@MichaelKetchel MichaelKetchel changed the title Mdk/enhance wlan support Draft: Mdk/enhance wlan support Nov 5, 2024
@MichaelKetchel MichaelKetchel changed the title Draft: Mdk/enhance wlan support Mdk/enhance wlan support Nov 5, 2024
@MichaelKetchel MichaelKetchel marked this pull request as draft November 5, 2024 23:32
Michael Ketchel added 17 commits November 5, 2024 18:38
Improve error response of wlan endpoints when a non-existent interfac…
bdb4410 
…e is used. added a "current network" endpoint
Fixed formatting
9308302
Draft of ap radio info stuff
cc45c05
fixed a tyoi
7958b67
Cleanup commit, plus more data!
5767c3b
bump changelog
d984279
fix imports and duplicate defs
24a47cd
Fix formatting
24a1997
More cleanup, and armored up the network API against command injectio…
abbf8e2 
…n via interface name
Version bump
a7dc3ca
Version bump and format
f220072
Version bump and format
d71c40d
Fix some auto gateway config quirks
406d885
Add iw link endpoint
e1cbb91
Relocate iw link endpoint code
bcb6630
Merge branch 'dev' into mdk/enhance_wlan_support
21506aa 
# Conflicts:
#	debian/changelog
#	debian/wlanpi-core.install
#	debian/[email protected]
#	wlanpi_core/__main__.py
#	wlanpi_core/api/api_v1/endpoints/network_api.py
#	wlanpi_core/app.py
#	wlanpi_core/services/network_service.py
#	wlanpi_core/utils/general.py
Merge branch 'dev' into mdk/enhance_wlan_support
865921b 
# Conflicts:
#	debian/changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MichaelKetchel @joshschmelzle