Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate unique canonical emails #161

Merged
merged 4 commits into from
Aug 1, 2024
Merged

Generate unique canonical emails #161

merged 4 commits into from
Aug 1, 2024

Conversation

vbrik
Copy link
Contributor

@vbrik vbrik commented Jul 12, 2024

No description provided.

@vbrik vbrik requested a review from dsschult July 12, 2024 16:54
@vbrik
Copy link
Contributor Author

vbrik commented Jul 12, 2024

@dsschult no rush on this!

This branch does two things:
(1) add to krs.users.list_users the ability to filter by custom attributes
(2) generate unique canonical addresses when a user being created has the same name as an existing user.

Unlike my previous attempt, this implementation is fast because I don't have to retrieve info of all users, so hopefully won't be a problem for user-mgmt.

Copy link
Contributor

@dsschult dsschult left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vbrik vbrik merged commit 374fcad into master Aug 1, 2024
33 checks passed
@vbrik vbrik deleted the dup_cans2_clean2 branch August 1, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants