spec.bs: Change how updating IGs to an unknown executionMode behaves. #927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When joining IGs with unrecognized modes, we use "compatibility" for forward compatibility. Seems like we should do the same for updates. Note that neither this behavior nor the originally described behavior are what currently happens - we currently ignore unrecognized modes. Want to get approval for this before changing behvaior.
|
It seems this PR's behaviour is what's in the implementation now (1 CL in Dec made the change which meets what is described here). |
|
@domfarolino Mind taking a look at this tiny change? The code for this behaviour change landed last Dec (in the same CL that allowed updating exectionMode to "frozen-context", which got I2S approval and launched). So this spec change is a missing piece of that launch (that spec PR only mentioned the "frozen-context" part and forgot updating this) |
domfarolino
approved these changes
Feb 7, 2024
github-actions bot
added a commit
that referenced
this pull request
Feb 9, 2024
SHA: 2f6849b Reason: push, by JensenPaul Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When joining IGs with unrecognized modes, we use "compatibility" for forward compatibility. Seems like we should do the same for IG updates.
Note that neither the behavior this CL describes nor the originally described behavior are what currently happens - we currently ignore unrecognized modes. I want to get approval for this before changing behavior.
Preview | Diff