-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(workspace): stabilize development mode (VIV-1526) #1691
base: main
Are you sure you want to change the base?
Conversation
…m/Vonage/vivid-3 into VIV-1526-improve-development-mode
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1691 +/- ##
===========================================
Coverage 100.00% 100.00%
===========================================
Files 123 328 +205
Lines 1562 5656 +4094
Branches 108 718 +610
===========================================
+ Hits 1562 5656 +4094
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested the PR and one issue I found is that it is a lot slower for component changes (~3s vs ~13s). It seems that vite watch mode is much faster than doing a full build
Thanks for the feedback. It's a preliminary solution that's supposed to actually allow a working dev environment. For me it is a big improvement than the unlimited time waiting for a crush due to the the race condition in the builds :) |
I feel this is definitely an improvement on what we currently have. I think we should iterate on this to find ways to improve performance, but I'm a lot happier with changes actually being reflected in the browser and not having to re-run the build etc. |
In this PR:
In future PRs: