-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Various additions and fixes #37
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The rest seem fine on a read-through.
- Marking your artist entry as **approved**, preventing new users from editing that entry. | ||
- **Removing tags** associated with your entry | ||
- Providing **[personal descriptions](/docs/songs/song-entry-page#artists-personal-description)** for your albums and songs. | ||
- Uploading song files (such as .mp3s) directly to VocaDB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Uploading song files (such as .mp3s) directly to VocaDB | |
- Uploading song files (such as `.mp3`s) directly to VocaDB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Susko3 backticks don't seem to display properly, see the latest revision of song entry editing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I saw that, I guess my suggested change is not really important, everyone knows what an .mp3
is and knows that .mp3s
is not a real file extension.
descriptions** for your albums and songs. | ||
As a verified artist, your user account name is **displayed** on the | ||
artist entry page, and vice versa. You also gain access to the following actions: | ||
- Marking your artist entry as **approved**, preventing new users from editing that entry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's a "new user" in this context. Shouldn't this say "non-trusted" or "regular".
This is an issue with the original text as well, so it's fine to remain as-is in this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's a "new user" in this context. Shouldn't this say "non-trusted" or "regular".
This is an issue with the original text as well, so it's fine to remain as-is in this PR.
I assume it's used as an antonym to Trusted here (seems there's an expectation that long-time users become Trusted, at least by the wiki.) You're right it could be changed to be more clear though.
The biggest changes are condensing the requirements for tag entries on the tag page into one place in a bulleted list, and rewriting portions of the artist verification page to be a little less confusing and more visually appealing.
Other changes include small typo/grammar fixes, capitalizing VOCALOID and VOICEROID on Artist Types, etc.