WIP

Vizzuality · Dec 19, 2024 · cc106bd · cc106bd
1 parent 929bc78
commit cc106bd
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/api/src/modules/geo-coding/geocoders/cache.geocoder.ts b/api/src/modules/geo-coding/geocoders/cache.geocoder.ts
@@ -97,7 +97,7 @@ export class CacheGeocoder implements GeocoderInterface {
       locationAddressInput,
       locationAdminRegionInput,
     };
-    return Object.values(locationInfo).join(':');
+    return Object.values(locationInfo).join(':').toString();
   }
 
   async getLocationFromCache(

diff --git a/api/src/modules/geo-coding/strategies/point-of-production.geocoding.service.ts b/api/src/modules/geo-coding/strategies/point-of-production.geocoding.service.ts
@@ -86,6 +86,9 @@ export class PointOfProductionGeocodingStrategy extends BaseStrategy {
       let adminRegionId: string;
       let adminRegion: AdminRegion;
       let geoRegion: GeoRegion;
+      // TODO: Why are we doing this? In case the admin region cannot be found, to then delete the created geoRegion?
+      //       probably a better idea to do this in a single transacion, but we should check how it will affect the whole process if we
+      //       we want to make the whole import transactional
       try {
         adminRegionId = (
           await this.adminRegionService.getClosestAdminRegionByCoordinates(