BUGFIX: Fix setting srcRecordInfo during interleaving of checkpointin…

…g and RMW (microsoft#956) * Fix setting srcRecordInfo during checkpointing * Also for internal upsert --------- Co-authored-by: Hamdaan Khalid <[email protected]>
Vijay-Nirmal · Jan 25, 2025 · 0cd87b0 · 0cd87b0
1 parent 9a48a1c
commit 0cd87b0
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/libs/storage/Tsavorite/cs/src/core/Index/Tsavorite/Implementation/InternalRMW.cs b/libs/storage/Tsavorite/cs/src/core/Index/Tsavorite/Implementation/InternalRMW.cs
@@ -92,6 +92,9 @@ internal OperationStatus InternalRMW<TInput, TOutput, TContext, TSessionFunction
                         case LatchDestination.Retry:
                             goto LatchRelease;
                         case LatchDestination.CreateNewRecord:
+                            if (stackCtx.recSrc.LogicalAddress >= hlogBase.HeadAddress)
+                                srcRecordInfo = ref stackCtx.recSrc.GetInfo();
+
                             goto CreateNewRecord;
                         default:
                             Debug.Assert(latchDestination == LatchDestination.NormalProcessing, "Unknown latchDestination value; expected NormalProcessing");

diff --git a/libs/storage/Tsavorite/cs/src/core/Index/Tsavorite/Implementation/InternalUpsert.cs b/libs/storage/Tsavorite/cs/src/core/Index/Tsavorite/Implementation/InternalUpsert.cs
@@ -86,6 +86,9 @@ internal OperationStatus InternalUpsert<TInput, TOutput, TContext, TSessionFunct
                         case LatchDestination.Retry:
                             goto LatchRelease;
                         case LatchDestination.CreateNewRecord:
+                            if (stackCtx.recSrc.LogicalAddress >= hlogBase.HeadAddress)
+                                srcRecordInfo = ref stackCtx.recSrc.GetInfo();
+
                             goto CreateNewRecord;
                         default:
                             Debug.Assert(latchDestination == LatchDestination.NormalProcessing, "Unknown latchDestination value; expected NormalProcessing");