-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pagination #344
Pagination #344
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉 Thank you for your contribution! Your pull request has been submitted successfully. A maintainer will review it as soon as possible. Support us by ⭐starring our repository!
@Vignesh025 video for that Pagination.-.Made.with.Clipchamp.1.1.mp4If you want any change please tell me |
@raj-adi00 The pagination is working well, but the cluster map on the campgrounds page isn’t visible. |
@Vignesh025 I don't have map key so it is not visible because I commented that part which was asking for key. But while pushing i un commented it |
@Sowmiyajayakumar uncommented those lines |
@raj-adi00 , Resolve the conflicts. |
@Vignesh025 resolved. Please add label to it |
@raj-adi00 The pagination isn’t working now. Could you please check it out? |
@Vignesh025 check it now. |
@raj-adi00 The search functionality isn’t working. Please make sure it’s fully functional and working as expected. |
📋 Description
This PR adds pagination to sort, search and find nearest page in campgrounds. I am displaying total page. And you can go to any page by changing input. If you input exceeds page limit it won't change and it can't below 1. So you can go directly on any page. There is prev and next button to increase pagination by 1 or decrease by 1.
There is one variable in campgrounds.js at controller which is controlling number of items per page. You just need to update that to change number of contents. In my demo video i set it to 3 but in code i am going to commit i have set it to 10. You can change that varialble named campgroundperPage to control number of items in a page.
Also i have disabled map i didn't have map key so it is not visible in my demo video. I have changed the code back so that won't be issue
🔨 Changes Made
I have updated backend code to send data as per page and i have added pagination button. In pagination.js i am controlling all the function.
✅ Checklist
Before submitting the PR, please make sure you have completed the following:
🏷️ Types of Changes
What type of changes does your code introduce? (Check all that apply)
🤝 Related Issues
📸 Screenshots (if applicable)
Reminder:
Please ensure your pull request is made to the
test
branch, notmain
.Thank you for contributing to VigneshDevHub! We look forward to reviewing your PR and getting it merged!