Remove unused getting unity version method

VeyronSakai · Apr 28, 2024 · 1f3e099 · 1f3e099
1 parent 7eea967
commit 1f3e099
Showing 1 changed file with 11 additions and 13 deletions.
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
@@ -38,14 +38,17 @@ jobs:
     needs: paths-filter
     if: ${{ (github.event_name == 'pull_request' && needs.paths-filter.outputs.should-build == 'true') || github.event_name == 'workflow_dispatch'}}
     runs-on: ubuntu-latest
+    outputs:
+      unity-version: ${{ steps.get-unity-version.outputs.unity-version }}
     steps:
       - uses: actions/checkout@v4
         with:
           sparse-checkout: ProjectSettings/ProjectVersion.txt
           clean: "${{ env.CLEAN }}"
       - name: Get Unity version
+        id: get-unity-version
         run: |
-          echo "UNITY_VERSION=$(grep "m_EditorVersion:" < ProjectSettings/ProjectVersion.txt | cut -d" " -f2)" >> "${GITHUB_ENV}"
+          echo "unity-version=$(grep "m_EditorVersion:" < ProjectSettings/ProjectVersion.txt | cut -d" " -f2)" >> "${GITHUB_OUTPUT}"
 
   android:
     name: Android
@@ -57,11 +60,9 @@ jobs:
       - uses: actions/checkout@v4
         with:
           clean: "${{ env.CLEAN }}"
-      - name: Get Unity version
-        run: |
-          echo "UNITY_VERSION=$(grep "m_EditorVersion:" < ProjectSettings/ProjectVersion.txt | cut -d" " -f2)" >> "${GITHUB_ENV}"
       - name: Android Build
         env:
+          UNITY_VERSION: ${{ needs.get-unity-version.outputs.unity-version }}
           ANDROID_NDK_ROOT: "/Applications/Unity/Hub/Editor/${UNITY_VERSION}/PlaybackEngines/AndroidPlayer/NDK"
         run: |
           /Applications/Unity/Hub/Editor/"${UNITY_VERSION}"/Unity.app/Contents/MacOS/Unity \
@@ -81,10 +82,9 @@ jobs:
       - uses: actions/checkout@v4
         with:
           clean: "${{ env.CLEAN }}"
-      - name: Get Unity version
-        run: |
-          echo "UNITY_VERSION=$(grep "m_EditorVersion:" < ProjectSettings/ProjectVersion.txt | cut -d" " -f2)" >> "${GITHUB_ENV}"
       - name: iOS Build
+        env:
+          UNITY_VERSION: ${{ needs.get-unity-version.outputs.unity-version }}
         run: |
           /Applications/Unity/Hub/Editor/"${UNITY_VERSION}"/Unity.app/Contents/MacOS/Unity \
             -quit \
@@ -103,10 +103,9 @@ jobs:
       - uses: actions/checkout@v4
         with:
           clean: "${{ env.CLEAN }}"
-      - name: Get Unity version
-        run: |
-          echo "UNITY_VERSION=$(grep "m_EditorVersion:" < ProjectSettings/ProjectVersion.txt | cut -d" " -f2)" >> "${GITHUB_ENV}"
       - name: macOS Build
+        env:
+          UNITY_VERSION: ${{ needs.get-unity-version.outputs.unity-version }}
         run: |
           /Applications/Unity/Hub/Editor/"${UNITY_VERSION}"/Unity.app/Contents/MacOS/Unity \
             -quit \
@@ -125,10 +124,9 @@ jobs:
       - uses: actions/checkout@v4
         with:
           clean: "${{ env.CLEAN }}"
-      - name: Get Unity version
-        run: |
-          echo "UNITY_VERSION=$(grep "m_EditorVersion:" < ProjectSettings/ProjectVersion.txt | cut -d" " -f2)" >> "${GITHUB_ENV}"
       - name: macOS Build
+        env:
+          UNITY_VERSION: ${{ needs.get-unity-version.outputs.unity-version }}
         run: |
           /Applications/Unity/Hub/Editor/"${UNITY_VERSION}"/Unity.app/Contents/MacOS/Unity \
             -quit \