Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(e2e): re-enable flame_game e2e test #881

Merged
merged 4 commits into from
Nov 13, 2023

Conversation

alestiago
Copy link
Contributor

Status

READY

Description

Removes commented flame_game e2e test since the blocking issue is closed.

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@alestiago alestiago self-assigned this Nov 10, 2023
@alestiago alestiago requested a review from a team as a code owner November 10, 2023 10:56
@alestiago alestiago changed the title ci: re-enable flame_game e2e test ci(e2e): re-enable flame_game e2e test Nov 10, 2023
tomarra
tomarra previously approved these changes Nov 11, 2023
@alestiago
Copy link
Contributor Author

I've open a follow-up issue (#884) to tackle the below 100% coverage test expectation that caused the workflow to fail in the first commit (943541f)

@alestiago alestiago merged commit d991437 into main Nov 13, 2023
30 checks passed
@alestiago alestiago deleted the alestiago/enable-flame-e2e-test branch November 13, 2023 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants