[VEN-3073]: Add zkETH market to the Core pool on zkSync #510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkirka
force-pushed
the
feat/zksync-zketh
branch
from
5fc3e09 to
b7737e0
Compare
chechu
reviewed
Feb 20, 2025
Debugger022
reviewed
Feb 24, 2025
| ); | ||
| }); | ||
|
|
||
| checkIsolatedPoolsComptrollers(); |
There was a problem hiding this comment.
These tests are failing for me
kkirka
commented
Feb 28, 2025
| @@ -122,6 +122,13 @@ const runPoolTests = async (pool: PoolMetadata, poolSupplier: string) => { | |||
| const balance = await supplyUnderlying?.balanceOf(poolSupplier); | |||
| const supplyAmountScaled = initialSupplyAmount.gt(balance) ? balance : initialSupplyAmount; | |||
| const originalSupplyMarketBalance = await supplyMarket?.balanceOf(poolSupplier); | |||
| const supplyCap = await comptroller.supplyCaps(supplyMarket?.address); | |||
| const nextTotalSupply = (await supplyMarket.totalSupply()) + supplyAmountScaled; | |||
There was a problem hiding this comment.
Total supply is in vTokens while supplyAmountScaled and supplyCap are in underlying. We could either multiply total supply by the exchange rate here, or just skip checking the cap and just set it to infinity instead, even if it isn't reached yet [*].
[*] This may interfere with other tests in a test suite. To avoid this, we could take a snapshot of the state before the check, do the checks, and then reset to the original state. But since checkIsolatedPoolsComptrollers is usually the last check we do, I guess we can just put a comment somewhere that it alters the state.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds VIPs for zksyncsepolia and zksyncmainnet to add zkETH market to the core pool on these networks.
Related PRs: