Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[VEN-2771] Renounce DEFAULT_ROLE for the Guardian #364

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[VEN-2771] Renounce DEFAULT_ROLE for the Guardian #364

wants to merge 1 commit into from

Conversation

web3rover
Copy link
Contributor

Description

Resolves VEN

@web3rover web3rover requested review from chechu and GitGuru7 August 27, 2024 09:13
@web3rover web3rover self-assigned this Aug 27, 2024
GitGuru7
GitGuru7 reviewed Oct 10, 2024
View reviewed changes
multisig/simulations/arbitrumone/vip-011/index.ts
describe("Post-VIP behavior", async () => {
it("execute vip", async () => {
await pretendExecutingVip(await vip011());
});
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think, we should add test to verify that role has been renounced successfully.

chechu
chechu reviewed Dec 19, 2024
View reviewed changes
Copy link
Member

@chechu chechu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to add the commands for Optimism, zkSync and Base

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chechu chechu chechu left review comments

@GitGuru7 GitGuru7 GitGuru7 left review comments

Assignees

@web3rover web3rover

Labels
multichain
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@web3rover @chechu @GitGuru7