feat(rpc): implement arrpc's link event
#1016
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this still doesn't work.. it still only switches to the window when i open a discord:// link that is supposed to jump to a message, but when i open a message link in the browser and then press open in discord it doesnt do anything |
|
You obviously misunderstand how to test this PR and the URI one. |
Vendicated
reviewed
Jan 24, 2025
Vendicated
reviewed
Jan 24, 2025
This implements deep links from web so message links and the like work over just invites work.
Covkie
force-pushed
the
feat/arrpc-deeplinks
branch
from
6eece90 to
71e9206
Compare
Vendicated
reviewed
Feb 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements deep links from web so message links and the like work over just invites working.
Depends on OpenAsar/arrpc/pull/128
I noticed we didn't implement this after double checking what I said in a #813 comment
note: you need to be signed out of web for discord to prompt you for this