Fix mana bottle effects #4548
Merged
Fix mana bottle effects #4548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- placing water no longer deletes blocks; replaceable blocks are replaced, waterloggable blocks are waterlogged, or water is potentially placed one block higher - dropping the entire inventory as the last use of the bottle no longer drops a single-use mana bottle in addition to also giving the player an empty bottle Also refactored the implementation to be a bit more modular.
TheRealWormbo
force-pushed
the
1.20-mana-bottle-water-fix
branch
from
dd731cd to
ae257f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4523: