Workaround for missing food properties in some modded food items

(fixes #4783)

Xplat/src/main/java/vazkii/botania/common/block/flower/generating/GourmaryllisBlockEntity.java

@@ -18,6 +18,7 @@
 import net.minecraft.sounds.SoundEvents;
 import net.minecraft.sounds.SoundSource;
 import net.minecraft.world.entity.item.ItemEntity;
+import net.minecraft.world.food.FoodProperties;
 import net.minecraft.world.item.ItemStack;
 import net.minecraft.world.level.block.state.BlockState;
 import net.minecraft.world.level.gameevent.GameEvent;
@@ -152,15 +153,18 @@ public void tickFlower() {
 	}
 
 	private static int getCooldown(int foodValue) {
-		return foodValue * FOOD_COOLDOWN_FACTOR;
+		return Math.max(1, foodValue * FOOD_COOLDOWN_FACTOR);
 	}
 
 	private static int getDigestingMana(int foodValue, double streakFactor) {
-		return (int) (foodValue * foodValue * FOOD_MANA_FACTOR * streakFactor);
+		return Math.max(1, (int) (foodValue * foodValue * FOOD_MANA_FACTOR * streakFactor));
 	}
 
 	private static int getFoodValue(ItemStack stack) {
-		return Math.min(MAX_FOOD_VALUE, stack.getItem().getFoodProperties().getNutrition());
+		FoodProperties foodProperties = stack.getItem().getFoodProperties();
+		// greetings to GregTech's Purple Drink, which claims to be edible but does not have food properties
+		int nutrition = foodProperties != null ? foodProperties.getNutrition() : 0;
+		return Math.min(MAX_FOOD_VALUE, nutrition);
 	}
 
 	@Override

web/changelog.md

@@ -36,6 +36,7 @@ thanks to Wormbo for a lot of work on this feature!
 * Fix: Redstone comparators no longer read signal strength 0 from special flowers other than the Thermalily
 * Fix: A comparator reading from a Thermalily through a solid block no longer keeps outputting a value after breaking the Thermalily
 * Fix: Potential crash issues in combination with mods that add colors have been resolved
+* Fix: Workaround for missing food properties in some items that are nonetheless flagged as edible
 * Language update:
   * de_de completed (Wormbo, thanks to Kartabass and PssbleTrngle for reviewing)
   * ko_kr updated (UnineVesiKass)