-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Variant Search #349
Draft
bencap
wants to merge
11
commits into
release-2025.2.0
Choose a base branch
from
feature/jstone-dev/variant-search
base: release-2025.2.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Variant Search #349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the selection logic assumed that the provided datum would be the same object as the object present in the data array of the heatmap/histogram. With the separate loading of clinical controls and subsequent association with variants out of the heatmap/histogram context, it was necessary to instead make datum selections based on some pre-set accessor field on the provided datum. This makes it significantly easier to select datum objects in cases where we do not have a guarnatee of object equality between internal heatmap/histogram datums and their externally selected counterparts.
Previously, the heatmap would select a datum even if the selection was null. With the newly implemented logic for selection via accessor field, this introduced a bug whereby the first heatmap datum with a null accessor field would be mistakenly selected.
This was
linked to
issues
Feb 24, 2025
Currently only returns MANE transcript match(es).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.