Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update docs to prepare for v1.0.0 release #133

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

axtloss
Copy link
Member

@axtloss axtloss commented Jan 17, 2025

This updates the docs to make them accurate for the upcoming 1.0.0 release

@axtloss axtloss requested a review from kbdharun January 17, 2025 20:24
}
```

Vib gets the plugin type from the `type` field: `0` means `BuildPlugin`, and `1` means `FinalizePlugin`. For this article, it should be set to `0`, as it does not cover the requirements for a finalize plugin.

`usecontainercmds` tells vib wether the plugin adds the relevant containerfile directives itself, or if vib should automatically prepend `CMD` to them, this allows plugins to do more advanced things outside of just specifing commands to run.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
`usecontainercmds` tells vib wether the plugin adds the relevant containerfile directives itself, or if vib should automatically prepend `CMD` to them, this allows plugins to do more advanced things outside of just specifing commands to run.
`usecontainercmds` tells vib whether the plugin adds the relevant containerfile directives itself, or if vib should automatically prepend `CMD` to them, this allows plugins to do more advanced things outside of just specifing commands to run.

@@ -182,6 +184,7 @@ Each stage has the following fields:
- `entrypoint`: the entry point for the container, it's similar to `cmd` but it's not overridden by the command passed to the container at runtime, useful to handle the container as an executable.
- `copy`: a list of files or directories to copy from another stage (or copy from host), useful to copy files from one stage to another.
- `modules`: a list of modules to use in the stage.
- `addincludes`: wether `includes.container` should be copied into this stage
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- `addincludes`: wether `includes.container` should be copied into this stage
- `addincludes`: whether `includes.container` should be copied into this stage

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants