Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retrieve depth texture from correct stage and for the correct eye #110

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mrxz
Copy link

@mrxz mrxz commented Nov 13, 2021

The current code in Display.cpp that retrieves the depth textures seems wrong. All the textures variables (m_UnityTextures, m_pNativeColorTextures and m_pNativeDepthTextures) have the stage as first dimension and the eye as second dimension. On top of that, when single pass rendering is used, only the (depth) texture of the left eye is relevant (as it's a texture array holding both eyes).

This is easily fixed, and AFAICS didn't cause any regression in what I was able to test. But additional testing would be nice, since I'm not even sure if I was testing it properly. The flags are set to vr::Submit_Default, so does that cause the compositor to infer the type of the texture? Or does this actually make the entire tex.depth.handle go unnoticed? In case of the latter, that might explain how this mistake went unnoticed and would require a fix to pick the right flags as well.

@1runeberg 1runeberg self-assigned this Nov 15, 2021
@1runeberg 1runeberg added the investigating We're investigating this issue either ourselves or with third parties label Nov 15, 2021
zite added a commit that referenced this pull request Mar 23, 2023
- Updated to SteamVR SDK 1.23.7
- Fix for unnecessary preinit #80
- Fix for incorrect reporting of eye position #86
- Fix for broken depth textures in some situations #110
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
investigating We're investigating this issue either ourselves or with third parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants