Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed bug in CCommand constructor that could append junk to the comma… #434

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixed bug in CCommand constructor that could append junk to the comma… #434

wants to merge 1 commit into from

Conversation

TravisWehrman
Copy link

…nd string

  • Missed copying the null terminator
  • Since m_pArgSBuffer is not initialized this problem can occur when the (command string buffer length) + 1 char in m_pArgSBuffer array happens to be non-zero.

@TravisWehrman
Fixed bug in CCommand constructor that could append junk to the comma…
2080684 
…nd string

* Missed copying the null terminator
* Since m_pArgSBuffer is not initialized this problem can occur when the (command string buffer length) + 1 char in m_pArgSBuffer array happens to be non-zero.
TotallyMehis added a commit to zm-reborn/zmr-game that referenced this pull request Jun 22, 2020
@TotallyMehis
Fixed bug in CCommand constructor that could append junk to the cmd
b7788fc 
ValveSoftware/source-sdk-2013#434
TotallyMehis added a commit to zm-reborn/zmr-game that referenced this pull request Oct 2, 2020
@TotallyMehis
Fixed bug in CCommand constructor that could append junk to the cmd
0b4c4a7 
ValveSoftware/source-sdk-2013#434
@SC1040-TS2
Copy link

…nd string

  • Missed copying the null terminator
  • Since m_pArgSBuffer is not initialized this problem can occur when the (command string buffer length) + 1 char in m_pArgSBuffer array happens to be non-zero.

Necroposter here. This also seems to affect the SP/src/tier1/convar.cpp as well. A programmer should have been pinged for this.

Bitl added a commit to FIREFIGHT-RELOADED/FIREFIGHT-RELOADED-src-sdk-2013 that referenced this pull request Mar 31, 2022
@Bitl
add various fixes from main repo 2
3b26616 
ValveSoftware/source-sdk-2013#363
ValveSoftware/source-sdk-2013#313
ValveSoftware/source-sdk-2013#434
ValveSoftware/source-sdk-2013#419
ValveSoftware/source-sdk-2013#406
FriskTheFallenHuman added a commit to FriskTheFallenHuman/mapbase-mp that referenced this pull request Nov 30, 2022
@FriskTheFallenHuman
fix(Tier1): Fixed bug in CCommand constructor that could append junk …
60b0b18 
…to the command string

See ValveSoftware#434
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TravisWehrman @SC1040-TS2