Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

renderervulkan: only consider modifiers support all the image properties #1057

Merged
merged 1 commit into from
Dec 14, 2023

Conversation

djdeath
Copy link

@djdeath djdeath commented Dec 14, 2023

If you have a modifier with image compression that is only support for some image formats like :

  • B8G8R8A8_UNORM : compression supported
  • B8G8R8A8_SRB : compression not supported

Then the render will not use compression but the modifier indicates it is present, so the compositor will try to make use of the side compressed data and this will lead to corruptions.

This fixes issues on Intel HW of Gfx9 generations.

If you have a modifier with image compression that is only support for
some image formats like :
   - B8G8R8A8_UNORM : compression supported
   - B8G8R8A8_SRB   : compression not supported

Then the render will not use compression but the modifier indicates it
is present, so the compositor will try to make use of the side
compressed data and this will lead to corruptions.

This fixes issues on Intel HW of Gfx9 generations.
@djdeath djdeath force-pushed the intel-gfx11-gfx9-fix branch from cbbe4c8 to 0f976e6 Compare December 14, 2023 19:17
@djdeath
Copy link
Author

djdeath commented Dec 14, 2023

Correcting this should only fix things on Gfx9.

@misyltoad misyltoad merged commit 243582c into ValveSoftware:master Dec 14, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants