Mfa improvements

Valour-Software · Jan 28, 2025 · 62b7234 · 62b7234
1 parent c50a124
commit 62b7234
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 5 deletions.
diff --git a/Valour/Client/Components/Menus/Modals/Users/Edit/EditUserInfoComponent.razor b/Valour/Client/Components/Menus/Modals/Users/Edit/EditUserInfoComponent.razor
@@ -261,8 +261,13 @@ else
             Description = "Enter your password to disable Multi-Factor Authentication",
             OnConfirmAsync = async (password) =>
             {
-                var result = await AuthService.RemoveMfaAsync(password);
-
+                var result = await ToastContainer.Instance.WaitToastWithTaskResult(new ProgressToastData<TaskResult>()
+                {
+                    ProgressTask = AuthService.RemoveMfaAsync(password),
+                    Title = "Removing MFA",
+                    Message = "Verifying password...",
+                });
+
                 if (result.Success)
                 {
                     _multiAuthMethods = new List<string>();

diff --git a/Valour/Client/Components/Menus/Modals/Users/Edit/SetupMfaModal.razor b/Valour/Client/Components/Menus/Modals/Users/Edit/SetupMfaModal.razor
@@ -77,8 +77,14 @@
 
     private async Task OnClickMultiFactorAuth()
     {
-        var multiResult = await AuthService.VerifyMfaAsync(_multiFactorCode);
-        if (multiResult.Success)
+        var result = await ToastContainer.Instance.WaitToastWithTaskResult(new ProgressToastData<TaskResult>()
+        {
+            ProgressTask = AuthService.VerifyMfaAsync(_multiFactorCode),
+            Title = "Setting up MFA",
+            Message = "Sending code...",
+        });
+
+        if (result.Success)
         {
             _complete = true;
             StateHasChanged();

diff --git a/Valour/Sdk/Services/AuthService.cs b/Valour/Sdk/Services/AuthService.cs
@@ -195,7 +195,7 @@ public async Task<TaskResult> VerifyMfaAsync(string code)
             return new TaskResult(false, result.Message);
 
         if (!result.Data)
-            return new TaskResult(true, "Invalid code");
+            return new TaskResult(false, "Invalid code");
 
         return TaskResult.SuccessResult;
     }