DungeonManager #430
Merged
DungeonManager #430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MSchmoecker
reviewed
May 10, 2024
MSchmoecker
reviewed
May 10, 2024
…onstructor functions to use new RoomConfig.ApplyConfig method
…AddPrefab instead
…nDungeonDBStarted.
…iececonfig.cs # Conflicts: # JotunnLib/Entities/CustomRoom.cs
…will parse a custom Theme value to string or attempt to parse vanilla Theme value to string
…7. Add method GetCustomRoomTheme to retrieve and return a new Room Theme, which was added to list of Room Themes.
…ad. Add IsCustomTheme flag. Combine GetCustomRoomTheme and GetVanillaRoomTheme functions.
probablykory
force-pushed
the
dungeons
branch
from
24ce92e to
ac77105
Compare
|
Rebased my branch to latest dev & Cherrypicked warp's PR changes. I've got more changes pending, but wanted to get these up. |
Fully removed Theme properties from RoomConfig & CustomRoom Formalized and documented static helpers in CustomRoom Several adjustments in DungeonManager to drive room selection without the Theme properties. Added a warning to DungeonManager.OnDungeonGeneratorSetupAvailableRooms to note when a generator has no defined themename and a Room.Theme.None value.
probablykory
commented
Sep 22, 2024
| @@ -251,7 +256,7 @@ private void OnZoneSystemSetupLocations() | |||
|
|
|||
| var env = kvp.Value; | |||
| env.FixReferences(true); | |||
| UnityEngine.Object.Instantiate<GameObject>(env, DungeonRoomContainer.transform); | |||
| UnityEngine.Object.Instantiate<GameObject>(env); // Intentionally omitting DungeonRoomContainer.transform | |||
There was a problem hiding this comment.
The env gameobject needs to be enabled in order for the component awakes to run.
MSchmoecker
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a new DungeonManager to Jotunn, allowing devs to add custom dungeon rooms to Valheim.